The reaction is such:
I've counted the number of carbons on each side: LHS=4, RHS=8 My working is such:
Chemistry Stack Exchange is a question and answer site for scientists, academics, teachers, and students in the field of chemistry. It only takes a minute to sign up.Sign up to join this community
Conceptually, we can think of this reaction as occurring in three stages. I've provided diagrams for the self-condensation of acetaldehyde, however you should be able to draw an analogous mechanism for the self-condensation of butanal (your aldehyde).
Your mechanism is essentially correct, except for the final elimination step, which as you've drawn it gives the wrong product.
As you guessed, the hydroxide is basic enough to cause enolisation of the aldehyde. Using KOH/MeOH, we form the enolate under thermodynamic control, essentially meaning the enolate is in equilibrium with the aldehyde.
The newly formed enolate may then attack an un-enolised molecule of the aldehyde (this is okay, since we've established that the aldehyde and the enolate are in equilibrium under these conditions). This nucleophilic attack leads to a beta-alkoxy aldehyde (the structure on the right), which will quickly pick up a proton to form a beta-hydroxy aldehyde.
Under these basic conditions (KOH, MeOH), we may be able to isolate the hydroxyaldehyde, however, they are prone to elimination (see below), which is what must happen to form the product you require.
The beta-hydroxyaldehyde formed (see above) is itself able to undergo enolisation, to form a new enolate. Rather than attacking another molecule of aldehyde intermolecularly, it may instead do an intramolecular E1cb type elimination, kicking out hydroxide (which is okay under these basic conditions), and giving you the product as drawn.
Your elimination step isn't the most favourable pathway to get rid of that alcohol, and infact the elimination only occurs under these conditions due to assistance form the carbonyl. The quote below puts this rather well.
You cannot normally eliminate water from an alcohol in basic solution as hydroxide is a bad leaving group. It is the carbonyl group that allows elimination here: these are E1cB reactions.
Source: Organic Chemistry, 2 ed., Warren, Clayden,
In your last elimination step the OH- should attack the hydrogen on the carbon between the alcohol and the ketone.
This then forms an enol, which then reverts to the ketone. This pushes the pi-bond across one carbon. The alcohol then leaves.
You should end up with almost the same molecule you've put down, but the alkene should be one to the left.